C++/C#/Java: Shared TaintTrackingImpl.qll#1790
Merged
Merged
Conversation
This file is now identical in all languages. Unifying this file led to the following changes: - The documentation spelling fixes and example from the C++ version were copied to the other versions and updated. - The steps through `NonLocalJumpNode` from C# were abstracted into a `globalAdditionalTaintStep` predicate that's empty for C++ and Java. - The `defaultTaintBarrier` predicate from Java is now present but empty on C++ and C#. - The C++ `isAdditionalFlowStep` predicate on `TaintTracking::Configuration` no longer includes `localFlowStep`. That should avoid some unnecessary tuple copying.
Contributor
Author
|
I forgot to list
|
aschackmull
reviewed
Aug 21, 2019
| final override predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) { | ||
| isAdditionalTaintStep(node1, node2) or | ||
| localAdditionalTaintStep(node1, node2) or | ||
| globalAdditionalTaintStep(node1, node2) |
Contributor
There was a problem hiding this comment.
Could we replace localAdditionalTaintStep(node1, node2) or globalAdditionalTaintStep(node1, node2) with defaultAdditionalTaintStep(node1, node2) in the shared code?
Contributor
Author
There was a problem hiding this comment.
That's fine with me. What do you think, @hvitved ?
Contributor
Author
|
I forgot the C++ IR taint tracking library, both here and in #1757. I'll fix that in a follow-up PR. |
aschackmull
approved these changes
Aug 22, 2019
hvitved
approved these changes
Aug 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file is now identical in all languages. Unifying this file led to the following changes:
were copied to the other versions and updated.
NonLocalJumpNodefrom C# were abstracted into aglobalAdditionalTaintSteppredicate that's empty for C++ and Java.defaultTaintBarrierpredicate from Java is now present but emptyon C++ and C#.
isAdditionalFlowSteppredicate onTaintTracking::Configurationno longer includeslocalFlowStep.That should avoid some unnecessary tuple copying.